refactor: begin unlock event with uses split lock (#2996)

x/lockup/keeper/lock.go

@@ -235,6 +235,10 @@ func (k Keeper) beginUnlock(ctx sdk.Context, lock types.PeriodLock, coins sdk.Co
 		k.hooks.OnStartUnlock(ctx, lock.OwnerAddress(), lock.ID, lock.Coins, lock.Duration, lock.EndTime)
 	}
 
+	ctx.EventManager().EmitEvents(sdk.Events{
+		createBeginUnlockEvent(&lock),
+	})
+
 	return nil
 }
 

x/lockup/keeper/msg_server.go

@@ -96,14 +96,7 @@ func (server msgServer) BeginUnlocking(goCtx context.Context, msg *types.MsgBegi
 		return nil, sdkerrors.Wrap(sdkerrors.ErrInvalidRequest, err.Error())
 	}
 
-	lock, err = server.keeper.GetLockByID(ctx, msg.ID)
-	if err != nil {
-		return nil, sdkerrors.Wrap(sdkerrors.ErrInvalidRequest, err.Error())
-	}
-
-	ctx.EventManager().EmitEvents(sdk.Events{
-		createBeginUnlockEvent(lock),
-	})
+	// N.B. begin unlock event is emitted downstream in the keeper method.
 
 	return &types.MsgBeginUnlockingResponse{}, nil
 }

x/lockup/keeper/msg_server_test.go

@@ -172,8 +172,8 @@ func (suite *KeeperTestSuite) TestMsgBeginUnlocking() {
 		suite.FundAcc(test.param.lockOwner, test.param.coinsInOwnerAddress)
 
 		msgServer := keeper.NewMsgServerImpl(suite.App.LockupKeeper)
-		c := sdk.WrapSDKContext(suite.Ctx)
-		resp, err := msgServer.LockTokens(c, types.NewMsgLockTokens(test.param.lockOwner, test.param.duration, test.param.coinsToLock))
+		goCtx := sdk.WrapSDKContext(suite.Ctx)
+		resp, err := msgServer.LockTokens(goCtx, types.NewMsgLockTokens(test.param.lockOwner, test.param.duration, test.param.coinsToLock))
 		suite.Require().NoError(err)
 
 		if test.param.isSyntheticLockup {
@@ -181,12 +181,14 @@ func (suite *KeeperTestSuite) TestMsgBeginUnlocking() {
 			suite.Require().NoError(err)
 		}
 
-		_, err = msgServer.BeginUnlocking(c, types.NewMsgBeginUnlocking(test.param.lockOwner, resp.ID, test.param.coinsToUnlock))
+		_, err = msgServer.BeginUnlocking(goCtx, types.NewMsgBeginUnlocking(test.param.lockOwner, resp.ID, test.param.coinsToUnlock))
 
 		if test.expectPass {
 			suite.Require().NoError(err)
+			suite.AssertEventEmitted(suite.Ctx, types.TypeEvtBeginUnlock, 1)
 		} else {
 			suite.Require().Error(err)
+			suite.AssertEventEmitted(suite.Ctx, types.TypeEvtBeginUnlock, 0)
 		}
 	}
 }